[PATCH] D90897: [llvm-objcopy] --only-keep-debug: place zero-size segment according to its parent segment

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/only-keep-debug.test:252
+Sections:
+  - Name:         .note
+    Type:         SHT_NOTE
----------------
jhenderson wrote:
> It's not clear from the test comments why we need the .got, .note and .text sections in this output. Either remove them or add comments explaining their purpose.
Added a comment.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/only-keep-debug.test:277
+    Align:    0x1000
+    Sections:
+      - Section: .note
----------------
jhenderson wrote:
> Note: @grimar is working on D90458 which changes how sections within segments are represented.
I can rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90897/new/

https://reviews.llvm.org/D90897