[PATCH] D90948: [WebAssembly] [WIP] call_indirect issues table number relocs

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

This looks great.

Are there no wasm-ld changes needed along with this change?   i.e. can they all be done as followups?  Its seems like perhaps they can?



================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:221
   unsigned NumGlobalImports = 0;
-  // NumTableImports is initialized to 1 to account for the hardcoded import of
-  // __indirect_function_table
----------------
Move this comment down to reset?


================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:611
+              WasmSym->setType(SymbolType.getValue());
+            }
+          }
----------------
I guess it makes sense to piggy back on the existing symbol handling at the end of the instruction...  but would having the symbol immediate come before the signature make more sense for this instruction?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90948/new/

https://reviews.llvm.org/D90948