[PATCH] D89142: llvmbuildectomy

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 05:48:28 PST 2020


serge-sans-paille added a comment.

> What's the next step after this current patch?

I'll take the example of `LLVMVEctorize`. Current build specification (including this patch) it split in two:

  add_llvm_component_library(LLVMVectorize
    LoadStoreVectorizer.cpp
    LoopVectorizationLegality.cpp
    LoopVectorize.cpp
    SLPVectorizer.cpp
    Vectorize.cpp
    VectorCombine.cpp
    VPlan.cpp
    VPlanHCFGBuilder.cpp
    VPlanPredicator.cpp
    VPlanSLP.cpp
    VPlanTransforms.cpp
    VPlanVerifier.cpp
  
    ADDITIONAL_HEADER_DIRS
    ${LLVM_MAIN_INCLUDE_DIR}/llvm/Transforms
    ${LLVM_MAIN_INCLUDE_DIR}/llvm/Transforms/Vectorize
  
    DEPENDS
    intrinsics_gen
    )

and

  LLVMBuildComponent(
      TYPE Library
      NAME Vectorize
      PARENT Transforms
      LIBRARY_NAME Vectorize
      REQUIRED_LIBRARIES Analysis Core Support TransformUtils
  )

Next step is two merge these two calls into a single one, at the `add_llvm_component_library` level. Thanks to the translation of the Python script into cmake script, this merge should be relatively easy. See how the intermediate step looks useful ;-) ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89142/new/

https://reviews.llvm.org/D89142



More information about the llvm-commits mailing list