[PATCH] D90505: [AMDGPU] Improve FLAT scratch detection

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 01:49:17 PST 2020


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.h:580
+    return isSegmentSpecificFLAT(MI) &&
+           AMDGPU::getFlatScratchInst(MI.getOpcode()) >= 0;
   }
----------------
If getFlatScratchInst is just a table lookup, is there any need to do the isSegmentSpecificFLAT test first?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90505/new/

https://reviews.llvm.org/D90505



More information about the llvm-commits mailing list