[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

[Victor Campos via Phabricator via llvm-commits]

vhscampos added a comment.

@Tyker This is causing another build failure in another example:

  [2858/4034] Building CXX object tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o
  FAILED: tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o 
  CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/lib/ccache/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/examples/Attribute -I/home/vicspe01/workspace/upstream/llvm-project/clang/examples/Attribute -I/home/vicspe01/workspace/upstream/llvm-project/clang/include -Itools/clang/include -Iinclude -I/home/vicspe01/workspace/upstream/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3  -fPIC  -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o -MF tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o.d -o tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o -c /home/vicspe01/workspace/upstream/llvm-project/clang/examples/Attribute/Attribute.cpp
  /home/vicspe01/workspace/upstream/llvm-project/clang/examples/Attribute/Attribute.cpp:73:16: error: no matching function for call to 'Create'
      D->addAttr(AnnotateAttr::Create(S.Context, "example(" + Str.str() + ")",
                 ^~~~~~~~~~~~~~~~~~~~
  tools/clang/include/clang/AST/Attrs.inc:885:24: note: candidate function not viable: requires at least 4 arguments, but 3 were provided
    static AnnotateAttr *Create(ASTContext &Ctx, llvm::StringRef Annotation, Expr * *Args, unsigned ArgsSize, const AttributeCommonInfo &CommonInfo = {SourceRange{}});
                         ^
  tools/clang/include/clang/AST/Attrs.inc:887:24: note: candidate function not viable: requires 6 arguments, but 3 were provided
    static AnnotateAttr *Create(ASTContext &Ctx, llvm::StringRef Annotation, Expr * *Args, unsigned ArgsSize, SourceRange Range, AttributeCommonInfo::Syntax Syntax);
                         ^
  1 error generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88645/new/

https://reviews.llvm.org/D88645