[PATCH] D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause.
sameeran joshi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 6 07:28:56 PST 2020
sameeranjoshi updated this revision to Diff 303453.
sameeranjoshi added a comment.
After the patch `D89385` there were regressions in this review before merging
it, probably due to `bool Pre(const parser::SpecificationPart &x)` was made to
`return true` hence the nodes under it were visited.
And the tests consisted of one such case which was causing `fatal internal error: CHECK(!ompContext_.empty())`.
Resolve symbols which were not found in `OpenMPDeclareSimdConstruct` to make this patch working.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90538/new/
https://reviews.llvm.org/D90538
Files:
flang/include/flang/Parser/parse-tree.h
flang/include/flang/Semantics/symbol.h
flang/lib/Semantics/resolve-directives.cpp
flang/test/Semantics/omp-clause-validity01.f90
flang/test/Semantics/omp-declarative-directive.f90
flang/test/Semantics/omp-do03.f90
flang/test/Semantics/omp-loop-simd01.f90
flang/test/Semantics/omp-simd02.f90
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90538.303453.patch
Type: text/x-patch
Size: 8142 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201106/9d58acf2/attachment.bin>
More information about the llvm-commits
mailing list