[llvm] 90f0e87 - [Arm][MC] Remove unused prefixes in .arch_extension fp tests

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 07:13:17 PST 2020


Author: David Spickett
Date: 2020-11-06T15:13:07Z
New Revision: 90f0e87653785dbaf27f37901d5ee7aa43810b13

URL: https://github.com/llvm/llvm-project/commit/90f0e87653785dbaf27f37901d5ee7aa43810b13
DIFF: https://github.com/llvm/llvm-project/commit/90f0e87653785dbaf27f37901d5ee7aa43810b13.diff

LOG: [Arm][MC] Remove unused prefixes in .arch_extension fp tests

idiv: There is no difference between Armv7m and Thumbv7M
behaviour so the specific CHECKs are not needed.
The errors for Armv7-a and Thumbv7-a will always
include "ARM" or "THUMB" respectively so they need their
own CHECK prefix, making CHECK-V7 redundant.

mp: Behaviour is dependent on whether the triple is v6/v7/v7M
regardless of being Arm or Thumb. So we don't need the more
specific CHECK-ARMv7M etc.

simd: Errors are either v7 only, or v7 and v8 so CHECK-V8
is not needed.

fp: Same as simd

Reviewed By: ostannard

Differential Revision: https://reviews.llvm.org/D90918

Added: 
    

Modified: 
    llvm/test/MC/ARM/directive-arch_extension-fp.s
    llvm/test/MC/ARM/directive-arch_extension-idiv.s
    llvm/test/MC/ARM/directive-arch_extension-mp.s
    llvm/test/MC/ARM/directive-arch_extension-simd.s

Removed: 
    


################################################################################
diff  --git a/llvm/test/MC/ARM/directive-arch_extension-fp.s b/llvm/test/MC/ARM/directive-arch_extension-fp.s
index b6688f166b6d..75c03a54ff4e 100644
--- a/llvm/test/MC/ARM/directive-arch_extension-fp.s
+++ b/llvm/test/MC/ARM/directive-arch_extension-fp.s
@@ -1,11 +1,11 @@
 @ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-V7 -check-prefix CHECK
 @ RUN: not llvm-mc -triple armv8-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-V8 -check-prefix CHECK
+@ RUN:   | FileCheck %s -check-prefix CHECK
 @ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-V7 -check-prefix CHECK
 @ RUN: not llvm-mc -triple thumbv8-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-V8 -check-prefix CHECK
+@ RUN:   | FileCheck %s -check-prefix CHECK
 
 	.syntax unified
 

diff  --git a/llvm/test/MC/ARM/directive-arch_extension-idiv.s b/llvm/test/MC/ARM/directive-arch_extension-idiv.s
index d2522279204f..e5ebd1ebc14c 100644
--- a/llvm/test/MC/ARM/directive-arch_extension-idiv.s
+++ b/llvm/test/MC/ARM/directive-arch_extension-idiv.s
@@ -1,15 +1,15 @@
 @ RUN: not llvm-mc -triple armv6-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-ARMv6 -check-prefix CHECK-V6
 @ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7 -check-prefix CHECK-V7
+@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7
 @ RUN: not llvm-mc -triple armv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7M -check-prefix CHECK-V7M
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7M
 @ RUN: not llvm-mc -triple thumbv6-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv6 -check-prefix CHECK-V6
 @ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7 -check-prefix CHECK-V7
+@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7
 @ RUN: not llvm-mc -triple thumbv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7M -check-prefix CHECK-V7M
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7M
 
 	.syntax unified
 

diff  --git a/llvm/test/MC/ARM/directive-arch_extension-mp.s b/llvm/test/MC/ARM/directive-arch_extension-mp.s
index 9046c2153155..953676561a6a 100644
--- a/llvm/test/MC/ARM/directive-arch_extension-mp.s
+++ b/llvm/test/MC/ARM/directive-arch_extension-mp.s
@@ -1,15 +1,15 @@
 @ RUN: not llvm-mc -triple armv6-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv6 -check-prefix CHECK-V6
+@ RUN:   | FileCheck %s -check-prefix CHECK-V6
 @ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7 -check-prefix CHECK-V7
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7
 @ RUN: not llvm-mc -triple armv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7M -check-prefix CHECK-V7M
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7M
 @ RUN: not llvm-mc -triple thumbv6-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv6 -check-prefix CHECK-V6
+@ RUN:   | FileCheck %s -check-prefix CHECK-V6
 @ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7 -check-prefix CHECK-V7
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7
 @ RUN: not llvm-mc -triple thumbv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7M -check-prefix CHECK-V7M
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7M
 
 	.syntax unified
 

diff  --git a/llvm/test/MC/ARM/directive-arch_extension-simd.s b/llvm/test/MC/ARM/directive-arch_extension-simd.s
index 14359c645229..05a82b445856 100644
--- a/llvm/test/MC/ARM/directive-arch_extension-simd.s
+++ b/llvm/test/MC/ARM/directive-arch_extension-simd.s
@@ -1,11 +1,11 @@
 @ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-V7 -check-prefix CHECK
 @ RUN: not llvm-mc -triple armv8-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-V8 -check-prefix CHECK
+@ RUN:   | FileCheck %s -check-prefix CHECK
 @ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-V7 -check-prefix CHECK
 @ RUN: not llvm-mc -triple thumbv8-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-V8 -check-prefix CHECK
+@ RUN:   | FileCheck %s -check-prefix CHECK
 
 	.syntax unified
 


        


More information about the llvm-commits mailing list