[PATCH] D90059: [ms] [llvm-ml] Support command-line defines

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

lg with tweaks:



================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6920
+  }
+  Var.Redefinable = true;
+  Var.IsText = true;
----------------
masm doesn't do it, but I think we should diag on redefinitions in -D flags, at least if the redefinition has a different value. that's likely always a bug in the  build system invoking us.


================
Comment at: llvm/test/tools/llvm-ml/command_line_defines.asm:15
+; CHECK-LABEL: test2:
+; CHECK-NOT: t2:
+
----------------
Can you test `ifdef` `elseifdef` too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90059/new/

https://reviews.llvm.org/D90059