[PATCH] D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

The unrelated change looks a) unrelated b) incorrect.

No test?

Can we drop `-filetype=nul` now that we have this?



================
Comment at: llvm/tools/llvm-ml/llvm-ml.cpp:77
 public:
-  MLOptTable() : OptTable(InfoTable, true) {}
+  MLOptTable() : OptTable(InfoTable, /*IgnoreCase=*/false) {}
 };
----------------
mention this change in cl description, add test for it

....but I don't think this change is correct?

```
C:\src>ml64 foo.asm /c /foasdf.obj /nologo
Microsoft (R) Macro Assembler (x64) Version 14.25.28614.0
Copyright (C) Microsoft Corporation.  All rights reserved.

 Assembling: foo.asm
MASM : warning A4018:invalid command-line option : /foasdf.obj
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90061/new/

https://reviews.llvm.org/D90061