[PATCH] D90916: [DebugInfo] Emit locations for large constant integers

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

Thanks for the patch! Overall this looks nice. We can also represent `long double`(128 bits) using `DW_OP_implicit_value`, any plans for supporting that too ? `long double` is non-trivial like it has different  representation on Power. It's pending on me since a while :(



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:206
 
+  if (AP.getDwarfVersion() >= 4 && !AP.getDwarfDebug()->tuneForSCE()) {
+    int NumBytes = Value.getBitWidth() / 8;
----------------
GDB also supports this. When I introduced this representation, I kept it exclusively GDB. Looking at DwarfDebug.cpp:2477 looks like someone changed it along the way.
Do you mind adding `GDB` also ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90916/new/

https://reviews.llvm.org/D90916