[PATCH] D90591: [ARM] Introduce t2DoLoopStartTP

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 04:33:54 PST 2020


samparker added a comment.

> I think that the code would still need a t2DoLoopStartTP instruction, so those change would all have to stay

Agreed, and I think this pseudo is very good idea.

> The findLoopComponents is used in other patches

But I think it could be then added with those patches when needed.

AFAICT the search you're describing would be trivial in MVETailPredication now that you've, almost, added start_loop_iterations - and that's my problem. I don't understand why adding a target-specific intrinsic and a tablegen pattern to match it would not be the favoured approach?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90591/new/

https://reviews.llvm.org/D90591



More information about the llvm-commits mailing list