[PATCH] D89483: [ARM][MachineOutliner] Emit more CFI instructions

[Momchil Velikov via Phabricator via llvm-commits]

chill planned changes to this revision.
chill added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:6196
+  int64_t LRPosEntry =
+      MF.addFrameInst(MCCFIInstruction::createSameValue(nullptr, DwarfLR));
+  BuildMI(MBB, It, DebugLoc(), get(ARM::CFI_INSTRUCTION))
----------------
danielkiss wrote:
> I would generate a `.cfi_restore lr` here for the first sight.
> The LR in the caller is saved on the stack probably so here the value of the LR is different because that is set by the `bl`.
Thanks, yes, that's right, "same value" is wrong here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89483/new/

https://reviews.llvm.org/D89483