[PATCH] D90903: [llvm-readelf/obj] - Allow dumping of ELF header even if some elements are corrupt.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. About the only other viable alternative I could think of would be to have the sections that are initialised early stored in some sort of container that does the lazy initialization itself, and then being a transparent object thereafter (like the Proxy design pattern). This would delay the error reporting until later. However, that would probably require call sites to be updated to handle errors where they don't currently, which I can understand might be a pain.



================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:249
 
+  bool IsContentValid() const { return ContentValid; }
+
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90903/new/

https://reviews.llvm.org/D90903