[PATCH] D90918: [Arm][MC] Remove unused prefix in .arch_extension fp test

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 02:45:32 PST 2020


DavidSpickett updated this revision to Diff 303386.
DavidSpickett added a comment.

- Remove unused prefixes from idiv, simd and mp tests as well.

We could remove `--check-prefix CHECK` since it's implicit
but I think it helps comprehension a bit here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90918/new/

https://reviews.llvm.org/D90918

Files:
  llvm/test/MC/ARM/directive-arch_extension-fp.s
  llvm/test/MC/ARM/directive-arch_extension-idiv.s
  llvm/test/MC/ARM/directive-arch_extension-mp.s
  llvm/test/MC/ARM/directive-arch_extension-simd.s


Index: llvm/test/MC/ARM/directive-arch_extension-simd.s
===================================================================
--- llvm/test/MC/ARM/directive-arch_extension-simd.s
+++ llvm/test/MC/ARM/directive-arch_extension-simd.s
@@ -1,11 +1,11 @@
 @ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-V7 -check-prefix CHECK
 @ RUN: not llvm-mc -triple armv8-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-V8 -check-prefix CHECK
+@ RUN:   | FileCheck %s -check-prefix CHECK
 @ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-V7 -check-prefix CHECK
 @ RUN: not llvm-mc -triple thumbv8-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-V8 -check-prefix CHECK
+@ RUN:   | FileCheck %s -check-prefix CHECK
 
 	.syntax unified
 
Index: llvm/test/MC/ARM/directive-arch_extension-mp.s
===================================================================
--- llvm/test/MC/ARM/directive-arch_extension-mp.s
+++ llvm/test/MC/ARM/directive-arch_extension-mp.s
@@ -1,15 +1,15 @@
 @ RUN: not llvm-mc -triple armv6-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv6 -check-prefix CHECK-V6
+@ RUN:   | FileCheck %s -check-prefix CHECK-V6
 @ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7 -check-prefix CHECK-V7
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7
 @ RUN: not llvm-mc -triple armv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7M -check-prefix CHECK-V7M
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7M
 @ RUN: not llvm-mc -triple thumbv6-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv6 -check-prefix CHECK-V6
+@ RUN:   | FileCheck %s -check-prefix CHECK-V6
 @ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7 -check-prefix CHECK-V7
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7
 @ RUN: not llvm-mc -triple thumbv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7M -check-prefix CHECK-V7M
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7M
 
 	.syntax unified
 
Index: llvm/test/MC/ARM/directive-arch_extension-idiv.s
===================================================================
--- llvm/test/MC/ARM/directive-arch_extension-idiv.s
+++ llvm/test/MC/ARM/directive-arch_extension-idiv.s
@@ -1,15 +1,15 @@
 @ RUN: not llvm-mc -triple armv6-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-ARMv6 -check-prefix CHECK-V6
 @ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7 -check-prefix CHECK-V7
+@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7
 @ RUN: not llvm-mc -triple armv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-ARMv7M -check-prefix CHECK-V7M
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7M
 @ RUN: not llvm-mc -triple thumbv6-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv6 -check-prefix CHECK-V6
 @ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7 -check-prefix CHECK-V7
+@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7
 @ RUN: not llvm-mc -triple thumbv7m-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-THUMBv7M -check-prefix CHECK-V7M
+@ RUN:   | FileCheck %s -check-prefix CHECK-V7M
 
 	.syntax unified
 
Index: llvm/test/MC/ARM/directive-arch_extension-fp.s
===================================================================
--- llvm/test/MC/ARM/directive-arch_extension-fp.s
+++ llvm/test/MC/ARM/directive-arch_extension-fp.s
@@ -1,11 +1,11 @@
 @ RUN: not llvm-mc -triple armv7-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-V7 -check-prefix CHECK
 @ RUN: not llvm-mc -triple armv8-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-V8 -check-prefix CHECK
+@ RUN:   | FileCheck %s -check-prefix CHECK
 @ RUN: not llvm-mc -triple thumbv7-eabi -filetype asm -o /dev/null 2>&1 %s \
 @ RUN:   | FileCheck %s -check-prefix CHECK-V7 -check-prefix CHECK
 @ RUN: not llvm-mc -triple thumbv8-eabi -filetype asm -o /dev/null 2>&1 %s \
-@ RUN:   | FileCheck %s -check-prefix CHECK-V8 -check-prefix CHECK
+@ RUN:   | FileCheck %s -check-prefix CHECK
 
 	.syntax unified
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90918.303386.patch
Type: text/x-patch
Size: 4736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201106/c4cf9e1a/attachment.bin>


More information about the llvm-commits mailing list