[PATCH] D90911: [VE][NFC] Refactor to support more than one calling conv

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 01:27:45 PST 2020


kaz7 added a comment.

Thank you for separating this!



================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:536
+    CCInfo2.AnalyzeCallOperands(CLI.Outs,
+                                getParamCC(CLI.CallConv, CLI.IsVarArg));
 
----------------
It's better to be `getParamCC(CLI.CallConv, true)`.  All calls using getParamCC should be written in the similar manner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90911/new/

https://reviews.llvm.org/D90911



More information about the llvm-commits mailing list