[PATCH] D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19).

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D87011#2376709 <https://reviews.llvm.org/D87011#2376709>, @ayermolo wrote:

> @ikudrin Can you elaborate on LLD changes. I recently started to look in to it. Reason I am interested in this, internally we are a looking in to using DWARF64, so I have bandwidth, and incentive, to help with it implementation and adoption.

I wouldn't expect LLD to need to do anything specific for DWARF64 support. It should generally speaking be treating the sections as opaque, in my opinion, and treat them no differently to other sections. If a user is mixing DWARF32 and DWARF64, then I'd say it's on their heads if relocations can't reach (just the same as it is if they're using DWARF32 but really need DWARF64). Any interactions LLD does have with the contents of the DWARF sections should be controlled via the DebugInfo library, and therefore if that library works for DWARF64, LLD doesn't need any special handling.

> and adoption.

We don't want to encourage unnecessary adoption of DWARF64 as it bloats debug data sizes unnecessarily in cases when the total debug data size is less than the DWARF32 limitations. DWARF64 should always be opt-in in my opinion, for the general purpose user (there might be some large code-bases out there where enabling it by default in their build system makes sense, but they're currently the exception, not the rule).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87011/new/

https://reviews.llvm.org/D87011