[PATCH] D90884: [SmallVector] Add a default small size.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In D90884#2377574 <https://reviews.llvm.org/D90884#2377574>, @silvas wrote:

> That seems artificially restrictive. What "bug" are you trying to prevent with that static_assert? It just seems to be a pain for users. Also <8 is way too strict. Maybe <=128 or something. Large types are not uncommon

My take is that if you have a large type and you want a SmallVector,, you should be explicit about the storage. I rather read `SmallVector<LargeType, 4>`  than `SmallVector<LargeType>` and have implicitly N=0.

I'm not sure I understand the size correctly, but right now any type > 24B would yield a N=0, wouldn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90884/new/

https://reviews.llvm.org/D90884