[PATCH] D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 14:01:32 PST 2020


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks, lgtm.



================
Comment at: llvm/unittests/Transforms/Utils/CodeExtractorTest.cpp:327
+  CE.findInputsOutputs(inputs, outputs, SinkingCands);
+  EXPECT_TRUE(outputs.size() == 0);
+
----------------
nit, it's a bit more idiomatic to write `EXPECT_EQ(outputs.size(), 0U)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90689/new/

https://reviews.llvm.org/D90689



More information about the llvm-commits mailing list