[PATCH] D90690: [llvm-objcopy][MachO] Fix adding multiple sections
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 5 13:03:33 PST 2020
alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.
besides a small nit this looks reasonable to me, I'd wait for @smeenai to take a look as well
================
Comment at: llvm/test/tools/llvm-objcopy/MachO/add-multiple-sections.test:11
+# RUN: llvm-readobj --sections --section-data %t.foo.bar.out \
+# RUN: | FileCheck %s -check-prefix=CHECK-A
+
----------------
nit: i'd probably rename CHECK-A -> CASE1, CHECK-B -> CASE3
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90690/new/
https://reviews.llvm.org/D90690
More information about the llvm-commits
mailing list