[PATCH] D90847: [AMDGPU] Enable more v3f16 tests, NFC

[Rodrigo Dominguez via Phabricator via llvm-commits]

rdomingu added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.load.1d.d16.ll:540
+; GFX8-PACKED-NEXT:    s_mov_b32 s7, s9
+; GFX8-PACKED-NEXT:    image_load v[0:1], v0, s[0:7] dmask:0x7 unorm d16
+; GFX8-PACKED-NEXT:    s_mov_b32 s0, 0xffff
----------------
AFAIK, gfx810 can't pack v3f16 when d16 is set because of a hardware bug. So this instruction should use 3 vgpr (not 2 vgpr).


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.load.1d.d16.ll:562
+; GFX9-NEXT:    s_mov_b32 s7, s9
+; GFX9-NEXT:    image_load v[0:1], v0, s[0:7] dmask:0x7 unorm d16
+; GFX9-NEXT:    v_mov_b32_e32 v2, 0xffff
----------------
gfx9 has the same hardware bug. So this instruction should use 3 vgpr (not 2 vgpr).


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.store.2d.d16.ll:125
+; GFX81-NEXT:    v_mov_b32_e32 v5, v4
+; GFX81-NEXT:    image_store v[2:5], v[0:1], s[0:7] dmask:0x7 unorm d16
 ; GFX81-NEXT:    s_endpgm
----------------
This instruction should use 3 vgpr (not 4 vgpr).


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.d16.dim.ll:79
+; PACKED: image_load v[0:1], v[0:2], s[0:7] dmask:0x7 unorm d16
+; GFX81: image_load v[0:1], v[0:2], s[0:7] dmask:0x7 unorm d16
+; GFX10: image_load v[0:1], v[0:2], s[0:7] dmask:0x7 dim:SQ_RSRC_IMG_3D unorm d16{{$}}
----------------
This instruction should use 3 vgpr (not 2 vgpr).


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.d16.dim.ll:115
+; PACKED: image_store v[2:3], v[0:1], s[0:7] dmask:0x7 unorm d16
+; GFX81: image_store v[2:3], v[0:1], s[0:7] dmask:0x7 unorm d16
+; GFX10: image_store v[2:3], v[0:1], s[0:7] dmask:0x7 dim:SQ_RSRC_IMG_2D unorm d16{{$}}
----------------
This is instruction should use 3 vgpr (not 2 vgpr).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90847/new/

https://reviews.llvm.org/D90847