[PATCH] D90462: [VE][TTI] don't advertise vregs/vops

Thu Nov 5 11:49:14 PST 2020

fhahn accepted this revision.
fhahn added a comment.

In D90462#2373328 <https://reviews.llvm.org/D90462#2373328>, @kaz7 wrote:

> @fhahn -san,  thank you for letting us know about `llvm/test/Analysis/CostModel/`.  I didn't know those regression tests.  We, @simoll and me actually, will add several cost-model tests in near future.  However, the purpose of this patch is disabling vector regs advertisement and it is tested well by newly added regression tests, in my opinion.  Therefore, I think this is LGTM.  Please let us know if you have any suggestions about it.   And thank you very much for reviewing this patch!

Sounds good to me with respect to the cost model tests.

LGTM.

================
Comment at: llvm/test/Transforms/LoopVectorize/VE/disable_lv.ll:2
+; RUN: opt < %s  -loop-vectorize -mtriple=ve-linux -S | FileCheck %s -check-prefix=VE 
+; RUN: opt < %s  -loop-vectorize -mtriple=x86_64-pc_linux -mcpu=core-avx2 -S | FileCheck %s -check-prefix=AVX
+
----------------
a bit unconventional but I guess it should not cause any problems down the road.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90462/new/

https://reviews.llvm.org/D90462