[PATCH] D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 11:42:31 PST 2020


clementval added inline comments.


================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:134
 bool HasDuplicateClausesInDirectives(const std::vector<Record *> &Directives) {
+  bool hasDuplicate = false;
   for (const auto &D : Directives) {
----------------
sameeranjoshi wrote:
> `nit:` - Is clang-tidy suggesting something? if not ignore me on this.
Good catch. clang-tidy is not followed always in TableGen backends but this one should be. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90770/new/

https://reviews.llvm.org/D90770



More information about the llvm-commits mailing list