[PATCH] D86142: [LLD] Search archives for non-tentative defintions.

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 10:18:03 PST 2020


sfertile updated this revision to Diff 303160.
sfertile marked an inline comment as done.
sfertile added a comment.

- Add comments about why we have the special lookup behaviour for common in archives..
- Use NonCommon as opposed to UnCommon
- switch second `if` to be an `else if` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86142/new/

https://reviews.llvm.org/D86142

Files:
  lld/ELF/InputFiles.cpp
  lld/ELF/InputFiles.h
  lld/ELF/Symbols.cpp
  lld/test/ELF/common-archive-lookup.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86142.303160.patch
Type: text/x-patch
Size: 11487 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201105/32b0a548/attachment.bin>


More information about the llvm-commits mailing list