[PATCH] D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros

Thu Nov 5 08:09:19 PST 2020

daltenty added inline comments.

================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp:35-37
-#if (defined(__GNUC__) && !defined(__ARM_EABI__) && !defined(__ia64__) &&      \
-     !(defined(_AIX) && defined(__ibmxl__)) && !defined(__MVS__) &&            \
-     !defined(__SEH__) && !defined(__USING_SJLJ_EXCEPTIONS__))
----------------
hubert.reinterpretcast wrote:
> Just noting that, since the fallback path attempts to use the functions in question by finding them at runtime, I guess none of the macros queried here is actually effective at preventing an attempt to register the frame.
> 
> It is still possible that the macros were effective at preventing a hard load-dependency on certain DLLs though. @daltenty, should `__SEH__` and `__USING_SJLJ_EXCEPTIONS__` continue to force the fallback path?
I think that seems advisable for the reason you note.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87114/new/

https://reviews.llvm.org/D87114