[PATCH] D90715: [VPlan] NFC: Change VFRange to take ElementCount

Vineet Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 07:30:39 PST 2020


vkmr added a comment.

Other than the minor nit, LGTM.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7173
+  assert(ElementCount::isKnownGT(Range.End, Range.Start) &&
+         "Trying to test an empty VF range.");
+  bool PredicateAtRangeStart = Predicate(Range.Start);
----------------
Nit: Add an `isEmpty()` method to `VFRange`. Removes the burden of knowing the condition for an empty range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90715/new/

https://reviews.llvm.org/D90715



More information about the llvm-commits mailing list