[PATCH] D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 07:11:32 PST 2020


clementval added inline comments.


================
Comment at: flang/test/Semantics/acc-clause-validity.f90:65
+
+  !ERROR: At most one IF clause can appear on the SHUTDOWN directive
+  !$acc shutdown if(.TRUE.) if(ifCondition)
----------------
kiranktp wrote:
> I may be wrong here. but i do not see these restrictions in OpenACC 3.0 standard for SHUTDOWN and INIT directive.
There is no written restriction about the `if` clause on most directives but this is kind of an implicit one since there is also no rule how two if condition would be combined together. Do you combined them with a logical `OR` or a logical `AND`. Since the clause takes a condition expression one can combined multiple conditions together in a single `if` clause.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90786/new/

https://reviews.llvm.org/D90786



More information about the llvm-commits mailing list