[PATCH] D90421: [IndVarSimplify][SimplifyIndVar] Move WidenIV to Utils/SimplifyIndVar. NFCI.

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

LGTM thanks for trimming down the API entry point! Utils/SimplifyIndVar.cpp seems a better fit as mentioned earlier.



================
Comment at: llvm/include/llvm/Transforms/Utils/SimplifyIndVar.h:19
+#include "llvm/Analysis/ScalarEvolutionExpressions.h"
+#include "llvm/IR/ConstantRange.h"
 #include "llvm/IR/ValueHandle.h"
----------------
those includes are not needed?


================
Comment at: llvm/include/llvm/Transforms/Utils/SimplifyIndVar.h:62
 
+/// Collect information about induction variables that are used by sign/zero
+/// extend operations. This information is recorded by CollectExtend and provides
----------------
It seems like this comment needs updating. It seems to mentioned some implementation details. Probably better to just state that it contains information about a widened IV or something along those lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90421/new/

https://reviews.llvm.org/D90421