[PATCH] D90402: [LoopFlatten] Run it earlier, just before IndVarSimplify

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 06:27:22 PST 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:527
+  if (EnableLoopFlatten)
+    LPM2.addPass(LoopFlattenPass());
+
----------------
dmgreen wrote:
> I think this one would be better put into a new LoopPassManager, LPM3, if flattening is enabled. I think that's how it's meant to work.
Cheers Dave. Like we discussed, I will convert LoopFlatten first to a Function pass as a loop pass that's deleting loops might be a bit tricky; looks like that is just the easiest to deal with this. Then, I will return to this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90402/new/

https://reviews.llvm.org/D90402



More information about the llvm-commits mailing list