[PATCH] D90421: [IndVarSimplify][LoopUtils] Move WidenIV to Utils. NFCI.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

In D90421#2375654 <https://reviews.llvm.org/D90421#2375654>, @nikic wrote:

> In D90421#2370552 <https://reviews.llvm.org/D90421#2370552>, @SjoerdMeijer wrote:
>
>> In D90421#2370323 <https://reviews.llvm.org/D90421#2370323>, @mkazantsev wrote:
>>
>>> I guess the better place for it would be Utils/SimplifyIndVars.h/cpp.
>>
>> I am sorry, but I am not following this. This was factored out from IndVarSimplify and moved to LoopUtils, so that I can reuse it in e.g. this loop pass here D90640 <https://reviews.llvm.org/D90640>.
>
> Just to be clear, we both have an IndVarSimplify pass (where you are extracting this code from) and a SimplifyIndVar utility (which is used by IndVarSimplify, but also e.g. LoopUnroll). I believe the suggestion here is to put this into the SimplifyIndVar transformation utility rather than LoopUtils.

Ah, luckily `SimplifyIndVar` and `IndVarSimplify` is not very confusing! ;-)

I think it's arbitrary if this should live in utility `SimplifyIndVar` or `LoopUtils` as both seem a good fit. Personally, I would probably put in LoopUtils, but am really happy to move it to SimplifyIndVar if that's what we want.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90421/new/

https://reviews.llvm.org/D90421