[PATCH] D89952: [SelectionDAG] Enable CTPOP optimization fine tuning

Thu Nov 5 02:25:39 PST 2020

davezarzycki added a comment.

In D89952#2371747 <https://reviews.llvm.org/D89952#2371747>, @spatel wrote:

> In D89952#2359357 <https://reviews.llvm.org/D89952#2359357>, @davezarzycki wrote:
>
>> Rebase. No change.
>>
>> The patch now has no test suite impact because all of the vector CTPOP tests that should be eliminated before code gen have been removed on trunk/master.
>
> Is this a no-functional-change patch for cases that are not reduced in IR?

I believe so. I'm only an occasional contributor to LLVM, so I could be missing something subtle.

> Do we have regression test coverage for a target with a legal CTPOP vector instruction (like AArch64 `cnt`)?

As far as I can tell, the AArch64 test coverage for vector CTPOP is fairly sparse. I can try and expand it you want.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89952/new/

https://reviews.llvm.org/D89952