[PATCH] D90361: Prevent LICM and machineLICM from hoisting convergent operations

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 02:05:02 PST 2020


foad added a comment.

In D90361#2375045 <https://reviews.llvm.org/D90361#2375045>, @xiaoqing_wu wrote:

> @foad Please let me know if you have other questions or concerns regarding the change. Thanks.

I think it could at least do with a comment explaining that LICM is being more conservative than the documented meaning of "convergent".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90361/new/

https://reviews.llvm.org/D90361



More information about the llvm-commits mailing list