[PATCH] D90817: [RISCV] Use the 'si' lib call for (double (fp_to_sint/uint i32 X)) when F extension is enabled.

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 01:54:27 PST 2020


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM. I guess the old libcall was producing the correct result anyway, since the in-register representation is the same?



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:943
     SDValue Op0 = IsStrict ? N->getOperand(1) : N->getOperand(0);
+    if (getTypeAction(*DAG.getContext(), Op0.getValueType()) !=
+        TargetLowering::TypeSoftenFloat)
----------------
Maybe add a comment here describing the new behavior?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90817/new/

https://reviews.llvm.org/D90817



More information about the llvm-commits mailing list