[PATCH] D89787: [AsmParser] Add source location to all errors related to .cfi directives

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 13:42:25 PST 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM. One last comment



================
Comment at: llvm/test/MC/X86/cfi-scope-unclosed.s:1
 # RUN: not llvm-mc %s -filetype=obj -triple=x86_64-unknown-linux \
 # RUN:   -o /dev/null 2>&1 | FileCheck %s
----------------
If cfi-scope-errors.s includes the coverage perhaps delete the file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89787/new/

https://reviews.llvm.org/D89787



More information about the llvm-commits mailing list