[PATCH] D89787: [AsmParser] Add source location to all errors related to .cfi directives

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/MC/MCStreamer.cpp:970
 
-void MCStreamer::Finish() {
+void MCStreamer::Finish(SMLoc Loc) {
   if ((!DwarfFrameInfos.empty() && !DwarfFrameInfos.back().End) ||
----------------
Perhaps EndLoc is clearer.


================
Comment at: llvm/test/MC/X86/cfi-open-within-another-crash.s:15
  .cfi_startproc
- 
+# CHECK: [[@LINE-1]]:2: error: starting new .cfi frame before finishing the previous one
+
----------------
`[[@LINE+x]]` is a deprecated form. Use `[[#@LINE-1]]`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89787/new/

https://reviews.llvm.org/D89787