[PATCH] D88369: [lld][WebAssembly] Fix segfault in map file support
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 4 11:23:43 PST 2020
sbc100 added inline comments.
================
Comment at: lld/wasm/MapFile.cpp:83
+ return;
+ uint64_t fileOffset = chunk->outputSec->getOffset() + chunk->outputOffset;
uint64_t vma = -1;
----------------
How about if we just have fileOffset default to 0 if `chunk` is null? I think we still want to include all symbols in the map.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88369/new/
https://reviews.llvm.org/D88369
More information about the llvm-commits
mailing list