[PATCH] D90532: [TableGen] [IR] Eliminate unnecessary recursive help class.
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 4 09:59:22 PST 2020
tra added a comment.
Thank you for cleaning this up.
If you're tinkering with this, another possible cleanup would be to use `!setdagop` instead of `!foreach(...,!subst())`
E.g. https://github.com/llvm/llvm-project/blob/master/llvm/lib/Target/NVPTX/NVPTXIntrinsics.td#L7497
PatFrag IntrFrag = PatFrag<PFOperands,
!foreach(tmp, PFOperands, !subst(ops, Intr, tmp)), #### <==== this
!cond(!eq(Space, ".shared"): AS_match.shared,
!eq(Space, ".global"): AS_match.global,
1: AS_match.generic)>;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90532/new/
https://reviews.llvm.org/D90532
More information about the llvm-commits
mailing list