[PATCH] D90094: [BasicAA] Handle recursive queries more efficiently (NFCI)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 09:56:58 PST 2020


nikic added a comment.

In D90094#2369633 <https://reviews.llvm.org/D90094#2369633>, @asbirlea wrote:

> The issue I'd like to bring up is what is the impact on the actual AA results provided with this change. For compile time this is a clear gain, even if small.
> But for run time, I'm seeing a regression of 22% in singlesource/dhrystone_fldry (optimized build on haswell), and a 31% on another non-public benchmark.
> I'm also seeing a few nice gains, which may offset these regressions. So I'm trying to understand here, what's the difference in processing that leads to these discrepancies?

Thanks for running those tests! I'm trying to reproduce the Dhrystone fldry results, but wasn't able to produce a binary hash difference before/after this patch after trying various flag combinations (including `-fexperimental-new-pass-manager` and `-farch=haswell`). Would it be possible to share the CMake configuration that is being used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90094/new/

https://reviews.llvm.org/D90094



More information about the llvm-commits mailing list