[PATCH] D88540: [AMDGPU] Add amdgpu_gfx calling convention

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:1783-2265
+static void processPSInputArgs(SmallVectorImpl<ISD::InputArg> &Splits,
+                               CallingConv::ID CallConv,
+                               ArrayRef<ISD::InputArg> Ins, BitVector &Skipped,
+                               FunctionType *FType,
+                               SIMachineFunctionInfo *Info) {
   for (unsigned I = 0, E = Ins.size(), PSInputNum = 0; I != E; ++I) {
     const ISD::InputArg *Arg = &Ins[I];
----------------
sebastian-ne wrote:
> arsenm wrote:
> > Missing equivalent GlobalISel changes
> What would that be?
> The change here shouldn’t change behavior apart from checking the assert for amdgpu_gfx and I can’t find the same structure in AMDGPUCallLowering.cpp.
Should at least add the tests or run line for it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88540/new/

https://reviews.llvm.org/D88540