[PATCH] D89735: [ms] [llvm-ml] Support purging macro definitions

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 08:14:04 PST 2020


epastor added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:5579
+      break;
+    parseOptionalToken(AsmToken::EndOfStatement);
+  }
----------------
thakis wrote:
> Why do we accept an optional EndOfStatement after every comma?
MASM specifies that in list contexts, a trailing comma implies a line continuation... but only in list contexts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89735/new/

https://reviews.llvm.org/D89735



More information about the llvm-commits mailing list