[PATCH] D90760: [InstCombiner] Make LibCallSimplifier add extension attribute to ldexp arg.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 07:22:47 PST 2020


uweigand added a comment.

This doesn't look quite right to me.   ldexp has a signed "int" argument, so you always must use the "sext" sign extension attribute on that argument.

[Note that transforming a pow (2.0, uitofp (...)) to an ldexp is only even valid if the unsigned integer type is smaller than 32 bits.  But this seems to be handled correctly by getIntToFPVal.]


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90760/new/

https://reviews.llvm.org/D90760



More information about the llvm-commits mailing list