[PATCH] D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause

[Yashaswini Hegde via Phabricator via llvm-commits]

yhegde added a comment.

If RPP () function constructed like this 
void RequiresPositiveParameter(

  const C &clause, const parser::ScalarIntExpr &i, llvm::StringRef paramName="parameter");

It wont break the test cases. Otherwise suggested change requires fixes in ERROR messages of previous test cases also.  Shall I go ahead with this ?

In D89546#2369707 <https://reviews.llvm.org/D89546#2369707>, @kiranchandramohan wrote:

> LGTM. Have a nit comment inline about how to construct the message.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89546/new/

https://reviews.llvm.org/D89546