[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

Hi!

I found a new problem after this was turned on again in 51ff04567b2f <https://reviews.llvm.org/rG51ff04567b2f8d06b2062bd3ed72eab2e93e4466>.
With

  opt -S -o - bbi-49235.ll -memoryssa -gvn -dse -verify-memoryssa

I hit

  opt: ../lib/Analysis/MemorySSA.cpp:2063: void llvm::MemorySSA::verifyOrderingDominationAndDefUses(llvm::Function &) const: Assertion `&*ALI == *AAI && "Not the same accesses in the same order"' failed.

with bbi-49235.ll being

  define void @k() {
  entry:
    %tobool = icmp ne i16 1, 0
    %0 = xor i1 %tobool, true
    call void @llvm.assume(i1 %0)
    call void @f()
    ret void
  }
  
  declare void @f() local_unnamed_addr
  
  ; Function Attrs: nofree nosync nounwind willreturn
  declare void @llvm.assume(i1 noundef) #0
  
  attributes #0 = { nofree nosync nounwind willreturn }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87163/new/

https://reviews.llvm.org/D87163