[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.

[Kai Nacke via Phabricator via llvm-commits]

Kai updated this revision to Diff 302822.
Kai added a comment.
Herald added a subscriber: dexonsmith.

Sorry for taking so long - I was on vacation.

- Added an enumeration for the basic charsets
- Added an named constructor just for the basic charsets
- Updated the test cases

I like the addition of the enumeration. It simplifies the source in some parts.
However, I did not drop the function which uses iconv for conversion. This will be needed for some further extensions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88741/new/

https://reviews.llvm.org/D88741

Files:
  llvm/cmake/config-ix.cmake
  llvm/include/llvm/Config/config.h.cmake
  llvm/include/llvm/Support/CharSet.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/CharSet.cpp
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/CharSetTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88741.302822.patch
Type: text/x-patch
Size: 21828 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201104/7ebc4e3a/attachment.bin>