[PATCH] D90713: [TypeSize] Extend UnivariateLinearPolyBase with add/sub methods
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 4 04:23:32 PST 2020
dmgreen added a comment.
Can you just overload the + operator? Would that make the calling code more confusing?
I don't know this class very well so feel free to ignore me but I feel like it should be called "getWithIncrement" or something like it. That would be more like Type methods I've seen in the past like getWithNewBitwidth. Like I said if you are going for something else feel free to ignore me though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90713/new/
https://reviews.llvm.org/D90713
More information about the llvm-commits
mailing list