[llvm] 694c16a - [JITLink][ELF] Omit temporary labels in tests

Stefan Gränitz via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 02:04:44 PST 2020


Author: Stefan Gränitz
Date: 2020-11-04T10:03:15Z
New Revision: 694c16a82386d9d961b6b8b23acabcbda7e7d876

URL: https://github.com/llvm/llvm-project/commit/694c16a82386d9d961b6b8b23acabcbda7e7d876
DIFF: https://github.com/llvm/llvm-project/commit/694c16a82386d9d961b6b8b23acabcbda7e7d876.diff

LOG: [JITLink][ELF] Omit temporary labels in tests

Oneshot temporary labels for declaring function size can be omitted. Follow-up from D90331.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D90676

Added: 
    

Modified: 
    llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_common.s
    llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_relocations.s

Removed: 
    


################################################################################
diff  --git a/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_common.s b/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_common.s
index 865b3f8aa49a..33be9d5ddccb 100644
--- a/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_common.s
+++ b/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_common.s
@@ -16,8 +16,8 @@ load_common:
 # jitlink-check: *{8}(got_addr(elf_common.o, common_data)) = common_data
         movl    common_data at GOTPCREL(%rip), %eax
         ret
-.Lfunc_end0:
-        .size   load_common, .Lfunc_end0-load_common
+
+        .size   load_common, .-load_common
 
 # Check that common is zero-filled.
 # jitlink-check: *{4}(common_data) = 0

diff  --git a/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_relocations.s b/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_relocations.s
index 4ea2e9160561..eada709cfe3f 100644
--- a/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_relocations.s
+++ b/llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_relocations.s
@@ -17,8 +17,8 @@
         .type   main, at function
 main:
         retq
-.Lfunc_end0:
-        .size   main, .Lfunc_end0-main
+
+        .size   main, .-main
 
 # Test PCRel32 / R_X86_64_PC32 handling.
 # jitlink-check: decode_operand(test_pcrel32, 4) = named_data - next_pc(test_pcrel32)
@@ -27,16 +27,16 @@ main:
         .type   test_pcrel32, at function
 test_pcrel32:
         movl    named_data(%rip), %eax
-.Lend_test_pcrel32:
-         .size   test_pcrel32, .Lend_test_pcrel32-test_pcrel32
+
+         .size   test_pcrel32, .-test_pcrel32
 
         .globl  named_func
         .p2align       4, 0x90
         .type   named_func, at function
 named_func:
         xorq    %rax, %rax
-.Lend_named_func:
-        .size   named_func, .Lend_named_func-named_func
+
+        .size   named_func, .-named_func
 
 # Check R_X86_64_PLT32 handling with a call to a local function. This produces a
 # Branch32 edge that is resolved like a regular PCRel32 (no PLT entry created).
@@ -47,8 +47,8 @@ named_func:
         .type   test_call_local, at function
 test_call_local:
         callq   named_func
-.Lend_test_call_local:
-        .size   test_call_local, .Lend_test_call_local-test_call_local
+
+        .size   test_call_local, .-test_call_local
 
 # Check R_X86_64_PLT32 handling with a call to an external. This produces a
 # Branch32ToStub edge, because externals are not defined locally. During
@@ -61,8 +61,8 @@ test_call_local:
         .type   test_call_extern, at function
 test_call_extern:
         callq   extern_in_range32 at plt
-.Lend_test_call_extern:
-        .size   test_call_extern, .Lend_test_call_extern-test_call_extern
+
+        .size   test_call_extern, .-test_call_extern
 
 # Check R_X86_64_PLT32 handling with a call to an external via PLT. This
 # produces a Branch32ToStub edge, because externals are not defined locally.
@@ -77,8 +77,8 @@ test_call_extern:
         .type   test_call_extern_plt, at function
 test_call_extern_plt:
         callq   extern_out_of_range32 at plt
-.Lend_test_call_extern_plt:
-        .size   test_call_extern_plt, .Lend_test_call_extern_plt-test_call_extern_plt
+
+        .size   test_call_extern_plt, .-test_call_extern_plt
 
 # Test GOTPCREL handling. We want to check both the offset to the GOT entry and its
 # contents.
@@ -90,8 +90,8 @@ test_call_extern_plt:
         .type   test_gotpcrel, at function
 test_gotpcrel:
 	movl    named_data at GOTPCREL(%rip), %eax
-.Lend_test_gotpcrel:
-        .size   test_gotpcrel, .Lend_test_gotpcrel-test_gotpcrel
+
+        .size   test_gotpcrel, .-test_gotpcrel
 
 # Test REX_GOTPCRELX handling. We want to check both the offset to the GOT entry and its
 # contents.
@@ -103,8 +103,8 @@ test_gotpcrel:
         .type   test_rex_gotpcrelx, at function
 test_rex_gotpcrelx:
 	movq    external_data at GOTPCREL(%rip), %rax
-.Lend_test_rex_gotpcrelx:
-        .size   test_rex_gotpcrelx, .Lend_test_rex_gotpcrelx-test_rex_gotpcrelx
+
+        .size   test_rex_gotpcrelx, .-test_rex_gotpcrelx
 
         .type   named_data, at object
         .data


        


More information about the llvm-commits mailing list