[PATCH] D90686: [lld][ELF] Add additional time trace categories

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lld/ELF/Writer.cpp:2118
+  {
+    llvm::TimeTraceScope timeScope("Finalize synthetic sections");
+
----------------
MaskRay wrote:
> If we do something to support RISC-V -mrelax in the future (D77694), there is possibility that this needs to break down.
Yeah, I wasn't sure about this big block. One option would be to add a subscope in `finalizeSynthetic` that specifically names the section being finalized. We'll also want to split it into two parts, as suggested below, I think.


================
Comment at: lld/ELF/Writer.cpp:2175
+    //    correct values. They also might change after adding the thunks.
+    finalizeAddressDependentContent();
+    if (errorCount())
----------------
MaskRay wrote:
> finalizeAddressDependentContent is a special address assigning operation. It does not belong to "Finalize synthetic sections".
Okay. I'll split the finalize synthetic sections block into two parts, and add an additional scope for `finalizeAddressDependentContent`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90686/new/

https://reviews.llvm.org/D90686