[PATCH] D90539: Make CallInst::updateProfWeight emit i32 weights instead of i64

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D90539#2372744 <https://reviews.llvm.org/D90539#2372744>, @aeubanks wrote:

> Ideally they'd be i64, see https://reviews.llvm.org/D88609 where I tried doing that, but it was reverted multiple times due to uint64_t overflows and I gave up trying to fix the various issues. There are multiple instances of using uint64_t to do uint32_t arithmetic and checking for overflows, and I eventually got annoyed with all those and gave up.

Ah... iiuc, with 32 bit, overflow can be detected more easily?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90539/new/

https://reviews.llvm.org/D90539