[PATCH] D90725: [NFC] Use [MC]Register in register allocation

Gaurav Jain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 16:29:32 PST 2020


gjain marked an inline comment as done.
gjain added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocGreedy.cpp:474
+  MCRegister getCheapestEvicteeWeight(const AllocationOrder &Order,
+                                      LiveInterval &VirtReg, SlotIndex Start,
+                                      SlotIndex End, float *BestEvictWeight);
----------------
mtrofin wrote:
> I can't tell what the notation is here on line 474 - is it a blank space, or?
> 
> (if you ran clang-format, it's probably fine)
Not sure what's happening here. I think it's just phabricator noting that 2 spaces were added for indentation. Note I run `arc lint` before putting up changes which I believe would do clang format etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90725/new/

https://reviews.llvm.org/D90725



More information about the llvm-commits mailing list