[PATCH] D90724: [NFC] Use Register/MCRegister

Google Contributors to LLVM via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 15:23:46 PST 2020


google-llvm-upstream-contributions added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:40
   unsigned XorTermrOpc;
-  Register CondReg;
-  Register ExecReg;
+  MCRegister CondReg;
+  MCRegister ExecReg;
----------------
@critson  - Looking at the uses of CondReg and ExecReg, it seems they are always physical registers (never virtual/stack slots), is this correct?

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90724/new/

https://reviews.llvm.org/D90724



More information about the llvm-commits mailing list