[PATCH] D90638: Introduce -dot-cfg-mssa option which creates dot-cfg style file with mssa comments included in source

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Needs some test coverage?



================
Comment at: llvm/include/llvm/Analysis/CFGPrinter.h:152-156
+      std::function<void(raw_string_ostream &, const BasicBlock &)>
+          HandleBasicBlock = [](raw_string_ostream &OS,
+                                const BasicBlock &Node) -> void { OS << Node; },
+      std::function<void(std::string &, unsigned &, unsigned)> HandleComment =
+          eraseComment) {
----------------
These could/should be `llvm::function_ref`, since they're not being captured/outliving the function call.

Could also skip the `-> void` since it's implicit (& the one statement lambda body seems clear enough that it's not returning anything, and the functor type written a line above has the `void` return type spelled out), if you like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90638/new/

https://reviews.llvm.org/D90638